Add BackHandler support on Android
#1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veyndan
commented
Sep 18, 2023
| @@ -92,3 +96,6 @@ public fun <A : AppService> TreehouseContent( | |||
| treehouseView.children.render() | |||
| } | |||
| } | |||
|
|
|||
| @Composable | |||
| internal expect fun platformOnBackPressedDispatcher(): OnBackPressedDispatcher | |||
There was a problem hiding this comment.
This function and its actual definitions are identical to that of RedwoodContent. When TreehouseContent is a wrapper around RedwoodContent, this function and its actual's can be removed.
veyndan
force-pushed
the
veyndan/2023-09-14/backhandler
branch
from
1112de5 to
54232e8
Compare
veyndan
force-pushed
the
veyndan/2023-09-14/backhandler
branch
from
54232e8 to
55e13f0
Compare
JakeWharton
approved these changes
Sep 18, 2023
redwood-compose/src/commonMain/kotlin/app/cash/redwood/compose/BackHandler.kt
Show resolved
Hide resolved
redwood-compose/src/commonMain/kotlin/app/cash/redwood/compose/BackHandler.kt
Show resolved
Hide resolved
...-treehouse-host/src/androidUnitTest/kotlin/app/cash/redwood/treehouse/TreehouseLayoutTest.kt
Show resolved
Hide resolved
|
|
||
| /** Redwood's [OnBackPressedCallback] but implementing [ZiplineService]. */ | ||
| @ObjCName("OnBackPressedCallbackService", exact = true) | ||
| public interface OnBackPressedCallbackService : ZiplineService { |
There was a problem hiding this comment.
Why doesn't this one extend OnBackPressedCallback?
There was a problem hiding this comment.
OnBackPressedCallback is an abstract class, so I can only extend it by making OnBackPressedCallbackService an abstract class. Per the ZiplineService KDoc, ZiplineService should be implemented by interfaces (i.e., not abstract classes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #324.