Simplify LazyListValue construction in test cases
#1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veyndan
commented
Sep 13, 2023
| items = emptyList(), | ||
| ) | ||
|
|
||
| private fun LazyListValue.copy( |
There was a problem hiding this comment.
Ideally, this'd be generated within LazyListValue.
There was a problem hiding this comment.
I'm guessing we don't want copy to be generated, as it'd need to be part of the public API which we don't want. Though these WidgetValue instances are so far exclusively used in tests, so maybe that doesn't matter?
There was a problem hiding this comment.
Test API definitely has more flexibility, although breaking it could still break people.
JakeWharton
approved these changes
Sep 13, 2023
veyndan
force-pushed
the
veyndan/2023-09-13/simplify-LazyListValue-construction
branch
from
257889a to
e00ec0e
Compare
veyndan
deleted the
veyndan/2023-09-13/simplify-LazyListValue-construction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to add more tests to this class, and I don't want to have to keep copy-pasting the construction of
LazyListValuewhen 90% of it will always be the same.