-
Notifications
You must be signed in to change notification settings - Fork 74
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reduce viewport updates in
LazyList for improved perf with Zipline
- Loading branch information
Showing
8 changed files
with
115 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 changes: 76 additions & 0 deletions
76
...t-widget/src/commonTest/kotlin/app/cash/redwood/lazylayout/widget/WindowedLazyListTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| /* | ||
| * Copyright (C) 2023 Square, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package app.cash.redwood.lazylayout.widget | ||
|
|
||
| import app.cash.redwood.Modifier | ||
| import app.cash.redwood.layout.api.Constraint | ||
| import app.cash.redwood.layout.api.CrossAxisAlignment | ||
| import app.cash.redwood.lazylayout.api.ScrollItemIndex | ||
| import app.cash.redwood.ui.Margin | ||
| import app.cash.redwood.widget.MutableListChildren | ||
| import app.cash.redwood.widget.Widget | ||
| import app.cash.turbine.test | ||
| import assertk.assertThat | ||
| import assertk.assertions.isEqualTo | ||
| import kotlin.test.Test | ||
| import kotlinx.coroutines.CoroutineScope | ||
| import kotlinx.coroutines.flow.MutableSharedFlow | ||
| import kotlinx.coroutines.flow.SharedFlow | ||
| import kotlinx.coroutines.launch | ||
| import kotlinx.coroutines.test.runTest | ||
|
|
||
| class WindowedLazyListTest { | ||
| @Test | ||
| fun updateViewPort() = runTest { | ||
| val windowedLazyList = FakeWindowedLazyList(this, "foo") | ||
| windowedLazyList.updateViewport(29, 38) | ||
| windowedLazyList.viewportChanges.test { | ||
| assertThat(awaitItem()).isEqualTo(10..50) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private class FakeWindowedLazyList<W : Any>( | ||
| private val scope: CoroutineScope, | ||
| override val value: W, | ||
| ) : WindowedLazyList<W>(NoOpListUpdateCallback) { | ||
| private val _viewportChanges = MutableSharedFlow<IntRange>() | ||
| val viewportChanges: SharedFlow<IntRange> = _viewportChanges | ||
|
|
||
| override var modifier: Modifier = Modifier | ||
| override val placeholder: Widget.Children<W> = MutableListChildren() | ||
|
|
||
| init { | ||
| onViewportChanged { firstPagedItemIndex, lastPagedItemIndex -> | ||
| scope.launch { | ||
| _viewportChanges.emit(firstPagedItemIndex..lastPagedItemIndex) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| override fun isVertical(isVertical: Boolean) = TODO() | ||
| override fun width(width: Constraint) = TODO() | ||
| override fun height(height: Constraint) = TODO() | ||
| override fun margin(margin: Margin) = TODO() | ||
| override fun crossAxisAlignment(crossAxisAlignment: CrossAxisAlignment) = TODO() | ||
| override fun scrollItemIndex(scrollItemIndex: ScrollItemIndex) = TODO() | ||
| } | ||
|
|
||
| private object NoOpListUpdateCallback : ListUpdateCallback { | ||
| override fun onInserted(position: Int, count: Int) = Unit | ||
| override fun onMoved(fromPosition: Int, toPosition: Int, count: Int) = Unit | ||
| override fun onRemoved(position: Int, count: Int) = Unit | ||
| } |