Address some PR feedback

cashapp · Sep 29, 2023 · db749b2 · db749b2
1 parent 8acf043
commit db749b2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/...ylayout-compose/src/commonTest/kotlin/app/cash/redwood/lazylayout/compose/LazyListTest.kt b/...ylayout-compose/src/commonTest/kotlin/app/cash/redwood/lazylayout/compose/LazyListTest.kt
@@ -55,7 +55,7 @@ class LazyListTest {
     assertThat(snapshot)
       .containsExactly(
         DefaultLazyListValue.copy(
-          placeholder = List(20) { TextValue(Modifier, "Placeholder") },
+          placeholder = List(30) { TextValue(Modifier, "Placeholder") },
         ),
       )
   }
@@ -91,7 +91,7 @@ class LazyListTest {
       .containsExactly(
         DefaultLazyListValue.copy(
           itemsAfter = expectedItemsAfter,
-          placeholder = List(20) { TextValue(Modifier, "Placeholder") },
+          placeholder = List(30) { TextValue(Modifier, "Placeholder") },
           items = List(expectedItemCount) { TextValue(Modifier, it.toString()) },
         ),
       )
@@ -124,7 +124,7 @@ class LazyListTest {
         DefaultLazyListValue.copy(
           itemsBefore = 35,
           itemsAfter = 25,
-          placeholder = List(20) { TextValue(Modifier, "Placeholder") },
+          placeholder = List(30) { TextValue(Modifier, "Placeholder") },
           items = List(40) { TextValue(Modifier, (it + 35).toString()) },
         ),
       )

diff --git a/...ylayout-uiview/src/commonMain/kotlin/app/cash/redwood/lazylayout/uiview/UIViewLazyList.kt b/...ylayout-uiview/src/commonMain/kotlin/app/cash/redwood/lazylayout/uiview/UIViewLazyList.kt
@@ -117,7 +117,10 @@ internal open class UIViewLazyList(
     override fun tableView(
       tableView: UITableView,
       numberOfRowsInSection: NSInteger,
-    ) = processor.size.toLong()
+    ): Long {
+      require(numberOfRowsInSection == 0L)
+      return processor.size.toLong()
+    }
 
     override fun tableView(
       tableView: UITableView,
@@ -146,7 +149,6 @@ internal open class UIViewLazyList(
       delegate = tableViewDelegate
       prefetchingEnabled = true
       rowHeight = UITableViewAutomaticDimension
-      estimatedRowHeight = 44.0
       separatorStyle = UITableViewCellSeparatorStyleNone
 
       registerClass(