Skip to content

Commit

Permalink
Removing clear background colors from UIViewLazyList, now that backgr…
Browse files Browse the repository at this point in the history
…ound color modifiers are supported, since clear backgrounds negatively impact performance (#2146)
  • Loading branch information
dnagler authored Jun 26, 2024
1 parent 99b5448 commit ce8b22d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Changed:
Fixed:
- Using a `data object` for a widget of modifier no longer causes schema parsing to crash.
- Ensuring `LazyList`'s `itemsBefore` and `itemsAfter` properties are always within `[0, itemCount]`, to prevent `IndexOutOfBoundsException` crashes.
- Removing clear background colors from `UIViewLazyList`, now that background color modifiers are supported, since clear backgrounds negatively impact performance.


## [0.12.0] - 2024-06-18
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,6 @@ internal open class UIViewLazyList :
delegate = tableViewDelegate
rowHeight = UITableViewAutomaticDimension
separatorStyle = UITableViewCellSeparatorStyleNone
backgroundColor = UIColor.clearColor

registerClass(
cellClass = LazyListContainerCell(UITableViewCellStyle.UITableViewCellStyleDefault, REUSE_IDENTIFIER)
Expand Down Expand Up @@ -295,8 +294,6 @@ internal class LazyListContainerCell(
override fun willMoveToSuperview(newSuperview: UIView?) {
super.willMoveToSuperview(newSuperview)

backgroundColor = UIColor.clearColor

// Confirm the cell is bound when it's about to be displayed.
if (superview == null && newSuperview != null) {
require(binding!!.isBound) { "about to display a cell that isn't bound!" }
Expand Down

0 comments on commit ce8b22d

Please sign in to comment.