Don't get stuck in programmatic scrolling (#1662)

cashapp · Nov 1, 2023 · 77f3ee0 · 77f3ee0
1 parent d51f1a6
commit 77f3ee0
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/...ylayout-uiview/src/commonMain/kotlin/app/cash/redwood/lazylayout/uiview/UIViewLazyList.kt b/...ylayout-uiview/src/commonMain/kotlin/app/cash/redwood/lazylayout/uiview/UIViewLazyList.kt
@@ -160,6 +160,14 @@ internal open class UIViewLazyList(
         scrollProcessor.onUserScroll(firstIndex, lastIndex)
       }
 
+      /**
+       * If the user begins a drag while we’re programmatically scrolling, well then we're not
+       * programmatically scrolling anymore.
+       */
+      override fun scrollViewWillBeginDragging(scrollView: UIScrollView) {
+        isDoingProgrammaticScroll = false
+      }
+
       override fun scrollViewDidEndScrollingAnimation(scrollView: UIScrollView) {
         isDoingProgrammaticScroll = false
       }
@@ -169,7 +177,6 @@ internal open class UIViewLazyList(
     tableView.apply {
       dataSource = this@UIViewLazyList.dataSource
       delegate = tableViewDelegate
-      prefetchingEnabled = true
       rowHeight = UITableViewAutomaticDimension
       separatorStyle = UITableViewCellSeparatorStyleNone
 

diff --git a/samples/emoji-search/ios-uikit/EmojiSearchApp/Info.plist b/samples/emoji-search/ios-uikit/EmojiSearchApp/Info.plist
@@ -4,6 +4,8 @@
 <dict>
 	<key>NSAppTransportSecurity</key>
 	<dict>
+		<key>NSAllowsArbitraryLoads</key>
+		<true/>
 		<key>NSExceptionDomains</key>
 		<dict>
 			<key>localhost</key>

diff --git a/test-app/ios-uikit/TestApp/Info.plist b/test-app/ios-uikit/TestApp/Info.plist
@@ -4,6 +4,8 @@
 <dict>
 	<key>NSAppTransportSecurity</key>
 	<dict>
+		<key>NSAllowsArbitraryLoads</key>
+		<true/>
 		<key>NSExceptionDomains</key>
 		<dict>
 			<key>localhost</key>