Add Row/LazyRow screenshot tests for align-self (#1285)

cashapp · Jun 28, 2023 · 68a2f02 · 68a2f02
1 parent 8874c53
commit 68a2f02
Show file tree

Hide file tree

Showing 17 changed files with 30 additions and 2 deletions.
diff --git a/...WithMarginAndDifferentAlignments[LTR].png → ...ginAndDifferentAlignments[LTR,Column].png b/...WithMarginAndDifferentAlignments[LTR].png → ...ginAndDifferentAlignments[LTR,Column].png
diff --git a/..._ComposeUiFlexContainerTest_layoutWithMarginAndDifferentAlignments[LTR,Row].png b/..._ComposeUiFlexContainerTest_layoutWithMarginAndDifferentAlignments[LTR,Row].png
diff --git a/...WithMarginAndDifferentAlignments[RTL].png → ...ginAndDifferentAlignments[RTL,Column].png b/...WithMarginAndDifferentAlignments[RTL].png → ...ginAndDifferentAlignments[RTL,Column].png
diff --git a/..._ComposeUiFlexContainerTest_layoutWithMarginAndDifferentAlignments[RTL,Row].png b/..._ComposeUiFlexContainerTest_layoutWithMarginAndDifferentAlignments[RTL,Row].png
diff --git a/...d-layout-shared-test/src/main/kotlin/app/cash/redwood/layout/AbstractFlexContainerTest.kt b/...d-layout-shared-test/src/main/kotlin/app/cash/redwood/layout/AbstractFlexContainerTest.kt
@@ -76,8 +76,12 @@ abstract class AbstractFlexContainerTest<T : Any> {
     verifySnapshot(container)
   }
 
-  @Test fun columnWithMarginAndDifferentAlignments() {
-    val container = flexContainer(FlexDirection.Column)
+  @Test fun layoutWithMarginAndDifferentAlignments(
+    @TestParameter flexDirectionEnum: FlexDirectionEnum,
+  ) {
+    assumeTrue(flexDirectionEnum in listOf(FlexDirectionEnum.Row, FlexDirectionEnum.Column))
+    val flexDirection = flexDirectionEnum.toFlexDirection()
+    val container = flexContainer(flexDirection)
     container.margin(Margin(start = 5.dp, end = 10.dp, top = 20.dp, bottom = 20.dp))
     movies.forEachIndexed { index, movie ->
       val modifier = when (index % 4) {

diff --git a/...WithMarginAndDifferentAlignments[LTR].png → ...ginAndDifferentAlignments[LTR,Column].png b/...WithMarginAndDifferentAlignments[LTR].png → ...ginAndDifferentAlignments[LTR,Column].png
diff --git a/....view_ViewFlexContainerTest_layoutWithMarginAndDifferentAlignments[LTR,Row].png b/....view_ViewFlexContainerTest_layoutWithMarginAndDifferentAlignments[LTR,Row].png
diff --git a/...WithMarginAndDifferentAlignments[RTL].png → ...ginAndDifferentAlignments[RTL,Column].png b/...WithMarginAndDifferentAlignments[RTL].png → ...ginAndDifferentAlignments[RTL,Column].png
diff --git a/....view_ViewFlexContainerTest_layoutWithMarginAndDifferentAlignments[RTL,Row].png b/....view_ViewFlexContainerTest_layoutWithMarginAndDifferentAlignments[RTL,Row].png
diff --git a/...WithMarginAndDifferentAlignments[LTR].png → ...ginAndDifferentAlignments[LTR,Column].png b/...WithMarginAndDifferentAlignments[LTR].png → ...ginAndDifferentAlignments[LTR,Column].png
diff --git a/...oseui_ComposeUiLazyListTest_layoutWithMarginAndDifferentAlignments[LTR,Row].png b/...oseui_ComposeUiLazyListTest_layoutWithMarginAndDifferentAlignments[LTR,Row].png
diff --git a/...WithMarginAndDifferentAlignments[RTL].png → ...ginAndDifferentAlignments[RTL,Column].png b/...WithMarginAndDifferentAlignments[RTL].png → ...ginAndDifferentAlignments[RTL,Column].png
diff --git a/...oseui_ComposeUiLazyListTest_layoutWithMarginAndDifferentAlignments[RTL,Row].png b/...oseui_ComposeUiLazyListTest_layoutWithMarginAndDifferentAlignments[RTL,Row].png
diff --git a/...WithMarginAndDifferentAlignments[LTR].png → ...ginAndDifferentAlignments[LTR,Column].png b/...WithMarginAndDifferentAlignments[LTR].png → ...ginAndDifferentAlignments[LTR,Column].png
diff --git a/...ayout.view_ViewLazyListTest_layoutWithMarginAndDifferentAlignments[LTR,Row].png b/...ayout.view_ViewLazyListTest_layoutWithMarginAndDifferentAlignments[LTR,Row].png
diff --git a/...WithMarginAndDifferentAlignments[RTL].png → ...ginAndDifferentAlignments[RTL,Column].png b/...WithMarginAndDifferentAlignments[RTL].png → ...ginAndDifferentAlignments[RTL,Column].png
diff --git a/...ayout.view_ViewLazyListTest_layoutWithMarginAndDifferentAlignments[RTL,Row].png b/...ayout.view_ViewLazyListTest_layoutWithMarginAndDifferentAlignments[RTL,Row].png