Enable incremental layouts by default (#2335)

Next step is to remove the option.
cashapp · Sep 26, 2024 · 3fe178c · 3fe178c
1 parent 616e91c
commit 3fe178c
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,7 +15,7 @@ Changed:
 Fixed:
 - Breaking the last remaining retain cycle in `UIViewLazyList`.
 - Don't leak the `DisplayLink` when a `TreehouseApp` is stopped on iOS.
-- Correctly handle dynamic size changes for child widgets of `Box`.
+- Correctly handle dynamic size changes for child widgets of `Box`, `Column`, and `Row`.
 - Correctly implement margins for `Box` on iOS.
 
 

diff --git a/...ut-shared-test/src/commonMain/kotlin/app/cash/redwood/layout/AbstractFlexContainerTest.kt b/...ut-shared-test/src/commonMain/kotlin/app/cash/redwood/layout/AbstractFlexContainerTest.kt
@@ -45,7 +45,7 @@ abstract class AbstractFlexContainerTest<T : Any> {
    * currently opt-in, but will soon be the only supported mode.
    */
   open val incremental: Boolean
-    get() = false
+    get() = true
 
   abstract val widgetFactory: TestWidgetFactory<T>
 

diff --git a/...napshots__/UIViewFlexContainerTestHost/testRecursiveLayoutHandlesResizes.v2.png b/...napshots__/UIViewFlexContainerTestHost/testRecursiveLayoutHandlesResizes.v2.png
diff --git a/...ayout-view/src/main/kotlin/app/cash/redwood/layout/view/ViewRedwoodLayoutWidgetFactory.kt b/...ayout-view/src/main/kotlin/app/cash/redwood/layout/view/ViewRedwoodLayoutWidgetFactory.kt
@@ -26,7 +26,7 @@ import app.cash.redwood.yoga.FlexDirection
 
 public class ViewRedwoodLayoutWidgetFactory(
   private val context: Context,
-  private val incremental: Boolean = false,
+  private val incremental: Boolean = true,
 ) : RedwoodLayoutWidgetFactory<View> {
   override fun Box(): Box<View> = ViewBox(context)