Sort the map arguments to optimize insertion performance #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates internal shifts which occur when the hashcodes of the keys are not ascending.
| // storage density and minimize runtime complexity, the ideal insertion order sorted, as it | ||
| // results in linear insertion into the array with no shifts. Thankfully `String.hashCode()` | ||
| // is specified by the documentation and thus safe to rely on across the JVM and Android. | ||
| for (argument in arguments.sortedBy { it.key.hashCode() }) { |
There was a problem hiding this comment.
Took me a few minutes to realize we're sorting at generation-time, not runtime. Cool!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates internal shifts which occur when the hashcodes of the keys are not ascending.
Closes #4. Manually verified this with debugger. Having #105 would ensure we don't regress.