Don't crash if burstValues() has only one argument #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
approved these changes
Oct 28, 2024
|
It’s totally unnecessary but I don’t think it’s worth a warning. Like an enum with only one constant? |
|
I think I would warn for that, too. Although it's less likely because the overhead of declaring an enum is higher. |
swankjesse
force-pushed
the
jwilson.1028.booleans
branch
from
d364b69 to
e631e2d
Compare
swankjesse
force-pushed
the
jwilson.1028.single_burstValues
branch
from
7d0f326 to
3d514a0
Compare
|
Yeah good call. Added a tracking issue! |
swankjesse
force-pushed
the
jwilson.1028.single_burstValues
branch
from
3d514a0 to
e8dd9ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.