Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial, limited implementation of burstValues() #45

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Initial, limited implementation of burstValues() #45

merged 5 commits into from
Oct 28, 2024

Conversation

swankjesse
Copy link
Collaborator

This requires some follow-up changes:

  • To use better names for non-constant symbols
  • To reject expressions that cannot be rewritten safely. Inline declarations in particular are problematic.
  • To cope with invalid names
  • To handle name collisions between arguments

#43

@squarejesse
Initial, limited implementation of burstValues()
b10ede9 
This requires some follow-up changes:
 - To use better names for non-constant symbols
 - To reject expressions that cannot be rewritten safely. Inline
   declarations in particular are problematic.
 - To cope with invalid names
 - To handle name collisions between arguments

#43
@squarejesse
Spotless
fa3b49a
@squarejesse
apiDump
4eaf636
@squarejesse
Fixup expectations
5ddc6a1
@swankjesse swankjesse merged commit 004bbac into main Oct 28, 2024
1 check passed
@swankjesse swankjesse deleted the jwilson.1027.burst_values branch October 28, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeWharton JakeWharton JakeWharton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swankjesse @JakeWharton @squarejesse