Support default arguments #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also don't generate anything that'll immediately be ignored. This creates more confusion than clarity. Closes: #18
|
I love this feature! |
JakeWharton
approved these changes
Oct 23, 2024
| @@ -58,5 +61,13 @@ internal fun IrPluginContext.allPossibleArguments( | |||
| val referenceClass = referenceClass(classId)?.owner ?: return null | |||
| if (!referenceClass.isEnumClass) return null | |||
| val enumEntries = referenceClass.declarations.filterIsInstance<IrEnumEntry>() | |||
| return enumEntries.map { Argument(parameter, parameter.type, it) } | |||
| val defaultValueSymbol = (parameter.defaultValue?.expression as? IrGetEnumValue)?.symbol | |||
There was a problem hiding this comment.
We talked about erroring if the default value is anything other than a constant enum value. Otherwise you could silently refactor out common defaults into a helper function (or something) and silently break the specialization.
There was a problem hiding this comment.
Lemme do that in a follow-up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also don't generate anything that'll immediately be ignored. This creates more confusion than clarity.
Closes: #18