Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GH release step on CI and tweak changelog styles #31

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Oct 17, 2024

Closes #26.

@Goooler
Copy link
Contributor Author

Goooler commented Oct 17, 2024

You can view the result at https://github.com/Goooler/burst/releases/tag/0.4.0.

@Goooler Goooler force-pushed the auto-release-on-ci branch from 1b8788a to 0dbaebd Compare October 17, 2024 06:12
@Goooler Goooler changed the title Add release workflow on CI and tweak changelog Add GH release step on CI and tweak changelog styles Oct 17, 2024
with:
body: ${{ steps.release_notes.outputs.release_notes }}
release_notes_file: RELEASE_NOTES.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the name of our file. We can rely on the default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used by --notes-file option, due to cashapp/licensee#357 (comment).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this writes the file, not reads it.

release_notes_file: RELEASE_NOTES.md

- name: Create GitHub release
run: gh release create ${{ github.ref_name }} --notes-file RELEASE_NOTES.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Goooler Goooler force-pushed the auto-release-on-ci branch from 0dbaebd to 2d99b39 Compare October 17, 2024 14:41
@JakeWharton JakeWharton merged commit dbd2017 into cashapp:main Oct 18, 2024
1 check passed
@Goooler Goooler deleted the auto-release-on-ci branch October 18, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change log should be in Keep A Changlog format
2 participants