-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GH release step on CI and tweak changelog styles #31
Conversation
You can view the result at https://github.com/Goooler/burst/releases/tag/0.4.0. |
1b8788a
to
0dbaebd
Compare
with: | ||
body: ${{ steps.release_notes.outputs.release_notes }} | ||
release_notes_file: RELEASE_NOTES.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the name of our file. We can rely on the default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used by --notes-file
option, due to cashapp/licensee#357 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this writes the file, not reads it.
release_notes_file: RELEASE_NOTES.md | ||
|
||
- name: Create GitHub release | ||
run: gh release create ${{ github.ref_name }} --notes-file RELEASE_NOTES.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
0dbaebd
to
2d99b39
Compare
589d209
to
a32fa86
Compare
Closes #26.