Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target JDK8 #25

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Target JDK8 #25

merged 2 commits into from
Oct 16, 2024

Conversation

swankjesse
Copy link
Collaborator

@swankjesse swankjesse commented Oct 16, 2024

This library is consumed by Okio which is extremely strict on which JDKs it targets. We don't need anything newer anyway.

Closes: #24

This library is consumed by Okio which is extremely strict
on which JDKs it targets. We don't need anything newer anyway.
Copy link
Collaborator

@JakeWharton JakeWharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toolchains 😬 . Might remove them in a follow-up...

@swankjesse
Copy link
Collaborator Author

Oooh good call. Yeah I want a nice concise way to safely target release 8 while actually leveraging the latest tech.

@swankjesse swankjesse merged commit cfa735c into main Oct 16, 2024
1 check passed
@swankjesse swankjesse deleted the jwilson.1016.jdk8 branch October 16, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Java 8
3 participants