Merge pull request #7 from cashapp/jwilson.1009.gradle_plugin

Basic Gradle plugin test

burst-gradle-plugin/src/test/kotlin/app/cash/burst/gradle/BurstGradlePluginTest.kt

@@ -18,6 +18,8 @@ package app.cash.burst.gradle
 
 import assertk.assertThat
 import assertk.assertions.contains
+import assertk.assertions.containsExactlyInAnyOrder
+import assertk.assertions.isFalse
 import assertk.assertions.isTrue
 import java.io.File
 import org.gradle.testkit.runner.GradleRunner
@@ -29,13 +31,34 @@ class BurstGradlePluginTest {
   fun happyPath() {
     val projectDir = File("src/test/projects/basic")
 
-    val taskName = ":lib:compileProductionExecutableKotlinJsZipline"
+    val taskName = ":lib:jvmTest"
     val result = createRunner(projectDir, "clean", taskName).build()
     assertThat(SUCCESS_OUTCOMES)
       .contains(result.task(taskName)!!.outcome)
 
-    val ziplineOut = projectDir.resolve("lib/build/zipline/Production")
-    assertThat(ziplineOut.resolve("basic-lib.zipline").exists()).isTrue()
+    val testResults = projectDir.resolve("lib/build/test-results")
+    val jvmTestXmlFile = testResults.resolve("jvmTest/TEST-CoffeeTest.xml")
+
+    val testSuite = readTestSuite(jvmTestXmlFile)
+
+    assertThat(testSuite.testCases.map { it.name }).containsExactlyInAnyOrder(
+      "test[jvm]",
+      "test_Decaf_Oat[jvm]",
+      "test_Regular_Milk[jvm]",
+      "test_Regular_None[jvm]",
+      "test_Decaf_Milk[jvm]",
+      "test_Decaf_None[jvm]",
+      "test_Double_Milk[jvm]",
+      "test_Double_None[jvm]",
+      "test_Regular_Oat[jvm]",
+      "test_Double_Oat[jvm]",
+    )
+
+    val originalTest = testSuite.testCases.single { it.name == "test[jvm]" }
+    assertThat(originalTest.skipped).isTrue()
+
+    val sampleVariant = testSuite.testCases.single { it.name == "test_Decaf_Oat[jvm]" }
+    assertThat(sampleVariant.skipped).isFalse()
   }
 
   private fun createRunner(

burst-gradle-plugin/src/test/kotlin/app/cash/burst/gradle/junitXml.kt

@@ -0,0 +1,65 @@
+/*
+ * Copyright (C) 2024 Cash App
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package app.cash.burst.gradle
+
+import java.io.File
+import javax.xml.parsers.DocumentBuilderFactory
+import org.w3c.dom.Element
+
+fun readTestSuite(xmlFile: File): TestSuite {
+  val builder = DocumentBuilderFactory.newInstance().newDocumentBuilder()
+  val document = builder.parse(xmlFile)
+  return document.documentElement.toTestSuite()
+}
+
+internal fun Element.toTestSuite(): TestSuite {
+  val testCases = mutableListOf<TestCase>()
+  for (i in 0 until childNodes.length) {
+    val item = childNodes.item(i)
+    if (item !is Element || item.tagName != "testcase") continue
+    testCases += item.toTestCase()
+  }
+
+  return TestSuite(
+    name = getAttribute("name"),
+    testCases = testCases,
+  )
+}
+
+internal fun Element.toTestCase(): TestCase {
+  var skipped = false
+  for (i in 0 until childNodes.length) {
+    val item = childNodes.item(i)
+    if (item is Element && item.tagName == "skipped") {
+      skipped = true
+    }
+  }
+
+  return TestCase(
+    name = getAttribute("name"),
+    skipped = skipped,
+  )
+}
+
+class TestSuite(
+  val name: String,
+  val testCases: List<TestCase>,
+)
+
+class TestCase(
+  val name: String,
+  val skipped: Boolean,
+)

burst-gradle-plugin/src/test/projects/basic/lib/build.gradle.kts

@@ -10,6 +10,7 @@ kotlin {
     commonTest {
       dependencies {
         implementation("app.cash.burst:burst:${project.property("burstVersion")}")
+        implementation(kotlin("test"))
       }
     }
   }

burst-gradle-plugin/src/test/projects/basic/lib/src/commonTest/kotlin/CoffeeTest.kt

@@ -0,0 +1,16 @@
+import app.cash.burst.Burst
+import kotlin.test.Test
+
+@Burst
+class CoffeeTest {
+  val log = mutableListOf<String>()
+
+  @Test
+  fun test(espresso: Espresso, dairy: Dairy) {
+    log += "running $espresso $dairy"
+  }
+}
+
+enum class Espresso { Decaf, Regular, Double }
+
+enum class Dairy { None, Milk, Oat }

burst-kotlin-plugin-tests/src/test/kotlin/app/cash/burst/kotlin/BurstKotlinPluginTest.kt

@@ -39,7 +39,6 @@ class BurstKotlinPluginTest {
         package app.cash.burst.testing
 
         import app.cash.burst.Burst
-        import kotlin.test.Ignore
         import kotlin.test.Test
 
         @Burst
@@ -50,19 +49,6 @@ class BurstKotlinPluginTest {
           fun test(espresso: Espresso, dairy: Dairy) {
             log += "running ${'$'}espresso ${'$'}dairy"
           }
-
-          // Generate this
-          @Test
-          @Ignore
-          fun x_test() {
-            x_test_Decaf_None()
-          }
-
-          // Generate this
-          @Test
-          fun x_test_Decaf_None() {
-            test(Espresso.Decaf, Dairy.None)
-          }
         }
 
         enum class Espresso { Decaf, Regular, Double }

burst-kotlin-plugin/src/main/kotlin/app/cash/burst/kotlin/BurstRewriter.kt

@@ -36,6 +36,7 @@ import org.jetbrains.kotlin.ir.expressions.impl.IrGetEnumValueImpl
 import org.jetbrains.kotlin.ir.symbols.IrClassSymbol
 import org.jetbrains.kotlin.ir.symbols.UnsafeDuringIrConstructionAPI
 import org.jetbrains.kotlin.ir.types.IrType
+import org.jetbrains.kotlin.ir.types.classFqName
 import org.jetbrains.kotlin.ir.types.getClass
 import org.jetbrains.kotlin.ir.types.starProjectedType
 import org.jetbrains.kotlin.ir.util.classId
@@ -87,9 +88,10 @@ internal class BurstRewriter(
       createVariant(originalDispatchReceiver, variantArguments)
     }
 
-    // Side-effect: add `@Ignore`
-    // TODO: if its' absent!
-    original.annotations += burstApis.ignoreClassSymbol.asAnnotation()
+    // Side-effect: drop `@Test` from the original's annotations.
+    original.annotations = original.annotations.filter {
+      it.type.classFqName != burstApis.testClassSymbol.starProjectedType.classFqName
+    }
 
     val result = mutableListOf<IrDeclaration>()
     result += createFunctionThatCallsAllVariants(originalDispatchReceiver, variants)