Show custom params in backfill configuration

cashapp · Jan 24, 2025 · a2756ac · a2756ac
1 parent 4a07a4a
commit a2756ac
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/service/src/main/kotlin/app/cash/backfila/ui/actions/BackfillCreateHandlerAction.kt b/service/src/main/kotlin/app/cash/backfila/ui/actions/BackfillCreateHandlerAction.kt
@@ -49,7 +49,7 @@ class BackfillCreateHandlerAction @Inject constructor(
     formFields[BackfillCreateField.EXTRA_SLEEP_MS.fieldId]?.ifNotBlank { createRequestBuilder.extra_sleep_ms(it.toLongOrNull()) }
     formFields[BackfillCreateField.BACKOFF_SCHEDULE.fieldId]?.ifNotBlank { createRequestBuilder.backoff_schedule(it) }
     val customParameters = formFields.filter { it.key.startsWith(BackfillCreateField.CUSTOM_PARAMETER_PREFIX.fieldId) }
-      .mapValues { it.value?.encodeUtf8() }
+      .map { it.key.removePrefix(BackfillCreateField.CUSTOM_PARAMETER_PREFIX.fieldId) to it.value?.encodeUtf8() }.toMap()
     if (customParameters.isNotEmpty()) {
       createRequestBuilder.parameter_map(customParameters)
     }

diff --git a/service/src/main/kotlin/app/cash/backfila/ui/pages/BackfillShowAction.kt b/service/src/main/kotlin/app/cash/backfila/ui/pages/BackfillShowAction.kt
@@ -8,6 +8,7 @@ import app.cash.backfila.ui.components.AutoReload
 import app.cash.backfila.ui.components.DashboardPageLayout
 import app.cash.backfila.ui.components.PageTitle
 import app.cash.backfila.ui.components.ProgressBar
+import app.cash.backfila.ui.pages.BackfillCreateAction.BackfillCreateField.CUSTOM_PARAMETER_PREFIX
 import javax.inject.Inject
 import javax.inject.Singleton
 import kotlinx.html.ButtonType
@@ -319,8 +320,13 @@ class BackfillShowAction @Inject constructor(
         label = "View",
         href = "#",
       ),
+    ),
+  ) + (parameters ?: mapOf()).map { (key, value) ->
+    DescriptionListRow(
+      label = key.removePrefix(CUSTOM_PARAMETER_PREFIX.fieldId),
+      description = value,
     )
-  )
+  }
 
   private fun TagConsumer<*>.Card(block: TagConsumer<*>.() -> Unit) {
     div("-mx-4 mb-8 px-4 py-8 overflow-x-auto shadow-sm ring-1 ring-gray-900/5 sm:mx-0 sm:rounded-lg sm:px-8 lg:col-span-2 lg:row-span-2 lg:row-end-2") {