feat: Use location.assign instead of location.replace for signin_redirect
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nighca
changed the title
location.assign instead of location.replace for signin_redirectlocation.assign instead of location.replace for signin_redirect
hsluoyz
changed the title
location.assign instead of location.replace for signin_redirectlocation.assign instead of location.replace for signin_redirect
|
@dacongda plz review |
dacongda
approved these changes
Oct 30, 2024
|
🎉 This PR is included in version 0.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Sdk.signin_redirectuseslocation.replaceto do redirection, which prevents the user from navigating back to the current page after being redirected to the login page.This PR changes it to
location.assignto preserve the history.