feat: fix different ways of building role links when domain patterns are enabled #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sagilio please review |
|
|
imf-code
changed the title
|
@imf-code plz fix CI errors:
|
hsluoyz
changed the title
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at addressing #351
Effectively causes each role in each domain to be considered their own role.
That is:
Should result in following link chain: alice in dom/1 -> role1 in dom/1 -> role1 in dom/* -> base-role in dom/*
This could lead to maximum hierarchy being reached faster then expected in some cases.
Performance and concurrency has been considered but not really tested.
Fix: #351