Update requirements.txt #160
Conversation
|
Fix the problem that video files whose path contains space or other special characters can't be supported. |
# test if the TEMP folder exists, when it does, delete it. Prevent the error when creating TEMP while the TEMP already exists
test if the TEMP folder already exists, when it does, delete it. Prevent the error when creating TEMP while the TEMP already exists.If we interrupted the editing process, it could leave the TEMP file undeleted, which causes errors when next edit. |
|
delete a comment which might disturb the deletion of TEMP |
加上了一些中文注释。解决了原作者遗留的一些问题： 1. 带空格的目录出问题 2. 视频过长时，因音频在内存中作 numpy.concat 连接处理，当内存较小时，会直接失败。我是把音频片段存在 TEMP 文件夹，用 ffmpeg 的 concat 处理。
an example of auto cut based on the keywords within the srt subtitle file
change float into int ( sample rate ). It's a history bug.
|
"Update requirements.txt" should not take 20 commits to do, most of these commits aren't even relevant to "updating requirements.txt" |
There was a problem hiding this comment.
This PR deletes necessary files, apart from adding another dependency that, as far as I know, is not needed. The change in the requirements.txt file from pytube to pytube3 looks good.
Please revert the deletions and make sure to only update the necessary dependencies.
Note that PR #169 does this already. Thus, this PR can be closed and #169 merged.
(PR #162, while implementing the same change as #169, doesn't include a nice description explaining why the PR is necessary.)
the pytube is updated to pytube3