What happens if we recursively map hashes in response to StrictOpenStuct?

[tom-lord]

This could prevent weird inconsistencies like this:

oo = RestfulResource::OpenObject.new({foo: :bar, baz: {nested: 123}})
#=> #<RestfulResource::OpenObject:0x000055dba392ab38 @inner_object=#<RestfulResource::StrictOpenStruct foo=:bar, baz={:nested=>123}>>

oo.foo #=> :bar
oo.baz #=> {nested: 123}
oo.baz.nested #=> UNDEFINED METHOD ON HASH
oo.baz[:nested] #=> 123

oo[:baz] #=> DEPRECATION WARNING

However, I'm concerned that this could be a breaking change in some cases due to:

NoMethodError: undefined method `fetch' for #<RestfulResource::OpenObject:0x000055dba392ab38>

...Maybe we'd also need to make :fetch call send for compatibility??!

[tom-lord]

Actually, I think this might be a misunderstanding... Should we be using has_one / has_many for scenarios like this?? https://github.com/carwow/restful_resource/blob/master/lib/restful_resource/associations.rb

However I think this is causing inconsistency where we use the library in not-so-restful ways, e.g. https://github.com/carwow/dealers_site/blob/master/api_client/lib/dealers_site_api_client/promotion.rb -- because you cannot really declare a has_one relationship when the response format varies so much??