Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return from RunWithCancel if cmd is kapp #1638

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

devanshuVmware
Copy link
Contributor

@devanshuVmware devanshuVmware commented Nov 5, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1627

Does this PR introduce a user-facing change?

NONE

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


@rohitagg2020
Copy link
Contributor

I am thinking if we should add a test case or not (As it has been reported by 2 different users)? We can mock the data in the path /var/run/secrets/kubernetes.io and try to run kctrl pkg release command and ensure that it completes successfully.

@100mik 100mik merged commit e8e5ce8 into carvel-dev:develop Nov 22, 2024
6 checks passed
@devanshuVmware devanshuVmware deleted the pkg-release-kctrl-fix branch November 22, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

kctrl package release does not work as expected inside a kubernetes pod
3 participants