Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding depth in case of git config in fetch section of app/package #1633

Merged

Conversation

rohitagg2020
Copy link
Contributor

Adding depth in case of git config in fetch section of app/package

Fixes #1632

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?


Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


@rohitagg2020 rohitagg2020 marked this pull request as ready for review October 7, 2024 15:07
pkg/apis/kappctrl/v1alpha1/types_fetch.go Outdated Show resolved Hide resolved
pkg/fetch/vendir.go Outdated Show resolved Hide resolved
test/e2e/kappcontroller/packageinstall_test.go Outdated Show resolved Hide resolved
@rohitagg2020 rohitagg2020 force-pushed the add-depth-in-vendir-git branch 3 times, most recently from 9085979 to eb3c198 Compare October 8, 2024 06:24
@rohitagg2020 rohitagg2020 force-pushed the add-depth-in-vendir-git branch from eb3c198 to 551ffc5 Compare October 8, 2024 06:24
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rohitagg2020 rohitagg2020 merged commit c6dbae6 into carvel-dev:develop Oct 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Consume depth flag of vendir in git fetch section of app/package spec
2 participants