Skip to content

Commit

Permalink
Updating default value for kube-api-qps and kube-api-burst for kapp
Browse files Browse the repository at this point in the history
Signed-off-by: Premkumar Bhaskal <[email protected]>
  • Loading branch information
prembhaskal committed Nov 22, 2023
1 parent 59d4642 commit f25dab1
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion pkg/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,16 @@ func (gc *Config) KappDeployRawOptions() []string {
gc.dataLock.RLock()
defer gc.dataLock.RUnlock()

kappOptions := make([]string, 0)
// Configure kapp to keep only 5 app changes as it seems that
// larger number of ConfigMaps negative affects other controllers on the cluster.
// Eventually kapp can be smart enough to keep minimal number of app changes.
// Set default first so that it can be overridden by user provided options.
return append([]string{"--app-changes-max-to-keep=5"}, gc.data.kappDeployRawOptions...)
kappOptions = append(kappOptions, "--app-changes-max-to-keep=5")
kappOptions = append(kappOptions, "--kube-api-qps=50", "--kube-api-burst=100")
kappOptions = append(kappOptions, gc.data.kappDeployRawOptions...)

return kappOptions
}

// AppDefaultSyncPeriod returns duration that is used by Apps
Expand Down

0 comments on commit f25dab1

Please sign in to comment.