Skip to content

Commit

Permalink
updating default value for apply and wait concurrency
Browse files Browse the repository at this point in the history
Signed-off-by: Premkumar Bhaskal <[email protected]>
  • Loading branch information
prembhaskal committed Nov 27, 2023
1 parent 420eda5 commit 98a565c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions pkg/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ func (gc *Config) KappDeployRawOptions() []string {
// Set default first so that it can be overridden by user provided options.
kappOptions = append(kappOptions, "--app-changes-max-to-keep=5")
kappOptions = append(kappOptions, "--kube-api-qps=50", "--kube-api-burst=100")
kappOptions = append(kappOptions, "--apply-concurrency=10", "--wait-concurrency=10")
kappOptions = append(kappOptions, gc.data.kappDeployRawOptions...)

return kappOptions
Expand Down
5 changes: 4 additions & 1 deletion pkg/config/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,10 @@ func Test_NewConfig_AppMinimumSyncPeriod(t *testing.T) {
}

func Test_NewConfig_KappDeployRawOptions(t *testing.T) {
defaultRawOptions := []string{"--app-changes-max-to-keep=5", "--kube-api-qps=50", "--kube-api-burst=100"}
defaultRawOptions := []string{
"--app-changes-max-to-keep=5", "--kube-api-qps=50", "--kube-api-burst=100",
"--apply-concurrency=10", "--wait-concurrency=10",
}
t.Run("with empty config value, returns just default", func(t *testing.T) {
secret := &v1.Secret{
ObjectMeta: metav1.ObjectMeta{
Expand Down

0 comments on commit 98a565c

Please sign in to comment.