Skip to content

Expose metrics to report time taken in fetch/template/deploy phase of app, pkgi, pkgr #3423

Expose metrics to report time taken in fetch/template/deploy phase of app, pkgi, pkgr

Expose metrics to report time taken in fetch/template/deploy phase of app, pkgi, pkgr #3423

Triggered via pull request December 5, 2023 19:23
Status Failure
Total duration 1m 54s
Artifacts

golangci-lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 9 warnings
lint: pkg/metrics/reconcile_time_metrics.go#L1
Missed header for check (goheader)
lint: pkg/pkgrepository/crd_app.go#L27
field `timeMetrics` is unused (unused)
lint
issues found
lint
Restore cache failed: Dependencies file is not found in /home/runner/work/kapp-controller/kapp-controller. Supported file pattern: go.sum
lint: pkg/metrics/reconcile_time_metrics.go#L10
exported: exported type ReconcileTimeMetrics should have comment or be unexported (revive)
lint: pkg/metrics/reconcile_time_metrics.go#L21
exported: exported function NewReconcileTimeMetrics should have comment or be unexported (revive)
lint: pkg/metrics/reconcile_time_metrics.go#L65
exported: exported method ReconcileTimeMetrics.RegisterAllMetrics should have comment or be unexported (revive)
lint: pkg/metrics/reconcile_time_metrics.go#L76
exported: exported method ReconcileTimeMetrics.RegisterOverallTime should have comment or be unexported (revive)
lint: pkg/metrics/reconcile_time_metrics.go#L80
exported: exported method ReconcileTimeMetrics.RegisterFetchTime should have comment or be unexported (revive)
lint: pkg/metrics/reconcile_time_metrics.go#L84
exported: exported method ReconcileTimeMetrics.RegisterTemplateTime should have comment or be unexported (revive)
lint: pkg/metrics/reconcile_time_metrics.go#L88
exported: exported method ReconcileTimeMetrics.RegisterDeployTime should have comment or be unexported (revive)
lint: pkg/metrics/app_metrics.go#L136
exported: exported method AppMetrics.GetReconcileAttemptCounterValue should have comment or be unexported (revive)