Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add torii index pending option #42

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

glihm
Copy link
Contributor

@glihm glihm commented May 2, 2024

No description provided.

@glihm glihm marked this pull request as draft May 2, 2024 19:43
@glihm
Copy link
Contributor Author

glihm commented May 2, 2024

I've one issue running in the CLI, but tests seems to pass.
Will check that.

glihm [slot] cargo run --bin slot d create glihm-pr42 torii  --index-pending --rpc https://api.cartridge.gg/rpc/starknet-sepolia --world 0x1234 --start-block 88888
    Finished dev [unoptimized + debuginfo] target(s) in 0.20s
     Running `target/debug/slot d create glihm-pr42 torii --index-pending --rpc 'https://api.cartridge.gg/rpc/starknet-sepolia' --world 0x1234 --start-block 88888`
Error: Cannot query field "indexPending" on type "ToriiConfig".
glihm [slot] 

@glihm
Copy link
Contributor Author

glihm commented May 2, 2024

Oh, maybe just related to the update to be pushed on the clusters I guess.

@glihm
Copy link
Contributor Author

glihm commented May 2, 2024

Depends on PR-1497 for internal deployment.

@glihm
Copy link
Contributor Author

glihm commented May 3, 2024

@tarrencev @broody once internal is merged this one will unlock ryo sepolia.

@broody
Copy link
Contributor

broody commented May 3, 2024

@tarrencev @broody once internal is merged this one will unlock ryo sepolia.

Cool, I'll add v0.7.0-alpha.0 to supported slot versions. Users will have to explicitly set to this version to use this feature for now.

@glihm glihm marked this pull request as ready for review May 3, 2024 22:13
@tarrencev tarrencev merged commit d2c8d62 into main May 6, 2024
3 checks passed
@tarrencev tarrencev deleted the feat/torii-index-pending branch May 6, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants