-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paginate leaderboard #153
Merged
Merged
Paginate leaderboard #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
notV4l
commented
Sep 19, 2023
•
edited
Loading
edited
- add a "local" param to default_auth.sh
- closes Paginate the leaderboard #121 ( need update once we can properly paginate with graphQL )
- closes Replace RYO hero image #151
- closes Move the back button into the footer #145
- fix some mobile issues
- start playing music on hustle click
- closes Fix clipping issue for random events on mobile #154
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
broody
reviewed
Sep 19, 2023
<VStack textAlign="center"> | ||
<Text>{response}</Text> | ||
<Text color="yellow.400"> | ||
{outcome.description && `* ${outcome.description} *`} | ||
</Text> | ||
</VStack> | ||
<Footer position={["absolute", "relative"]}> | ||
<Footer position={["relative", "relative"]}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmm I think we want the button to stick to bottom on mobile, otherwise it causes this issue: #159
Maybe we scale the image instead so it fits better on smaller screens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.