Request storage and drop cookie on auth #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
broody
force-pushed
the
login-cookie
branch
2 times, most recently
from
c260dd5 to
9c4449a
Compare
broody
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes logging in on Safari, currently we use Storage Access API to enable cookies which is needed for our webauthn login flow. However, the UX is not ideal as we have to drop a cookie in a popup first (per Storage Access requirement) and then Safari will prompt user to allow cookie access. https://webkit.org/blog/11545/updates-to-the-storage-access-api/
Once CHIPS (cookies having independent partition state) is implemented in our backend it should resolve this poor UX.