Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify layout in ui-next #1266

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

JunichiSugiura
Copy link
Collaborator

Move profile layout to ui-next and apply both in keychain and profile.

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui-next ✅ Ready (Inspect) Visit Preview Jan 10, 2025 3:39am

Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-create-createcontroller--with-timeout-error-chromium

components-connect-create-createcontroller--with-timeout-error-chromium

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

components-connect-create-createcontroller--with-light-mode-chromium

components-connect-create-createcontroller--with-light-mode-chromium

components-connect-create-createcontroller--with-theme-chromium

components-connect-create-createcontroller--with-theme-chromium

components-connect-create-createcontroller--with-generic-error-chromium

components-connect-create-createcontroller--with-generic-error-chromium

components-connect-create-createcontroller--default-chromium

components-connect-create-createcontroller--default-chromium

components-connect-create-createcontroller--with-validation-error-chromium

components-connect-create-createcontroller--with-validation-error-chromium


⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-connect-create-createcontroller--with-timeout-error-chromium

components-connect-create-createcontroller--with-timeout-error-chromium

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

components-connect-create-createcontroller--with-light-mode-chromium

components-connect-create-createcontroller--with-light-mode-chromium

components-connect-create-createcontroller--with-theme-chromium

components-connect-create-createcontroller--with-theme-chromium

components-connect-create-createcontroller--with-generic-error-chromium

components-connect-create-createcontroller--with-generic-error-chromium

components-connect-create-createcontroller--default-chromium

components-connect-create-createcontroller--default-chromium

components-connect-create-createcontroller--with-validation-error-chromium

components-connect-create-createcontroller--with-validation-error-chromium


⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant