Skip to content
quality

refactor: encapsulate Controller.cartridge #3068

Sign in to view logs

refactor: encapsulate Controller.cartridge

refactor: encapsulate Controller.cartridge #3068

Triggered via pull request December 16, 2024 02:38
@xJonathanLEIxJonathanLEI
opened #1153
dev/encapsulate_cartridge
Status Success
Total duration 6m 0s
Artifacts –

quality.yml

on: pull_request
ensure-wasm
1m 7s
ensure-wasm
ensure-windows
5m 47s
ensure-windows
clippy
2m 25s
clippy
rust-fmt
15s
rust-fmt
ts-lint
50s
ts-lint
Fit to window
Zoom out
Zoom in

Annotations

6 warnings
rust-fmt
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
ts-lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
ts-lint: packages/profile/src/components/achievements/trophies.tsx#L124
React Hook useEffect has a missing dependency: 'items'. Either include it or remove the dependency array
ts-lint: packages/profile/src/hooks/achievements.ts#L206
React Hook useEffect has missing dependencies: 'rawProgressions' and 'rawTrophies'. Either include them or remove the dependency array
ensure-wasm
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
clippy
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636