Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode signature from assertion response #56

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

broody
Copy link
Contributor

@broody broody commented Apr 4, 2024

AuthenticatorAssertionResponse expects the signature to be raw ECDSA, however, what's returned from authenticator is DER encoded ECDSA. This PR just decodes it and returns raw signature.

*Marking as draft until audit is done

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 63.70%. Comparing base (fd2336f) to head (8618af7).
Report is 1 commits behind head on main.

Files Patch % Lines
.../account_sdk/src/webauthn_signer/signers/device.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   64.14%   63.70%   -0.44%     
==========================================
  Files          16       16              
  Lines        1163     1171       +8     
==========================================
  Hits          746      746              
- Misses        417      425       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant