-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add load / delete ROS services. #1540
base: master
Are you sure you want to change the base?
Add load / delete ROS services. #1540
Conversation
Signed-off-by: Michael Grupp <[email protected]>
Signed-off-by: Michael Grupp <[email protected]>
|
cartographer_ros_msgs::LoadStateFromFile::Request& request, | ||
cartographer_ros_msgs::LoadStateFromFile::Response& response) { | ||
absl::MutexLock lock(&mutex_); | ||
// TODO(MichaelGrupp): this crashes if the file is invalid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not handle the case and return it with the status?
Should be easy with try / catch
rigth?
The load state from file worked as expected. I got it to crash with the delete call though, following error:
When I called delete onto a frozen trajectory nothing seemed to happen. Is that expected because there are still active constraints between the trajectories? |
Will address your points at some later point and let you know, I currently don't have too much time for this. |
When deleting the same submaps of multiple trajectories, because the reference number is not checked in the pose graph, repeated delete will cause the program to crash. |
See also: RFC 29
Signed-off-by: Michael Grupp [email protected]