Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Freight gRPC server configuration file. #32

Merged
merged 2 commits into from
Jan 25, 2018
Merged

Add Freight gRPC server configuration file. #32

merged 2 commits into from
Jan 25, 2018

Conversation

cschuet
Copy link

@cschuet cschuet commented Jan 25, 2018

No description provided.

@cschuet cschuet requested a review from gaschler January 25, 2018 09:11
gaschler
gaschler approved these changes Jan 25, 2018
View reviewed changes
Copy link

@gaschler gaschler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a prefix grpc_ to the filename so it's clear it won't work with default compile settings?

@cschuet
Copy link
Author

cschuet commented Jan 25, 2018

@wally-the-cartographer merge

@wally-the-cartographer
Copy link

Merge requested by authorized user cschuet. Merge queue now has a length of 1.

@wally-the-cartographer wally-the-cartographer merged commit 863c57b into cartographer-project:master Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaschler gaschler gaschler approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cschuet @wally-the-cartographer @gaschler @googlebot