This repository has been archived by the owner on Mar 12, 2024. It is now read-only.
Refactor update-proofs.sh
#209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidanoli
force-pushed
the
feature/update-proofs-refactor
branch
from
672840e to
82cf14d
Compare
ZzzzHui
reviewed
Jul 28, 2023
ZzzzHui
previously approved these changes
Aug 15, 2023
ZzzzHui
previously approved these changes
Aug 15, 2023
guidanoli
force-pushed
the
feature/update-proofs-refactor
branch
from
53b2a80 to
dba90fa
Compare
|
Adjusted |
- Add `yarn proofs:setup` - Add `yarn proofs:update` - Add `LibServerManager.sol` - Add `gen-proofs.sh` (back) - Add fs permissions to `helper` dir - Change `update-proofs.sh` - Remove several dependencies - Remove `genProofLibrary.ts` - Remove `genScript.ts` - Remove `jqFilter.awk` - Remove `requirements.txt`
- Remove `jq` as dependency - Run just `yarn` instead of `yarn install` - Use `yarn` to generate proofs and run tests - Give names to steps
guidanoli
force-pushed
the
feature/update-proofs-refactor
branch
from
dba90fa to
1561ba1
Compare
ZzzzHui
approved these changes
Aug 16, 2023
|
Thanks for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big PR. I plan to squash all commits later to make easier on the history.
Closes #208