Rollup enable by default #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpolitzer
reviewed
Oct 10, 2023
vfusco
force-pushed
the
feature/rollup-default
branch
from
a090bc7 to
670e3f4
Compare
vfusco
force-pushed
the
feature/rollup-default
branch
from
670e3f4 to
30b2704
Compare
edubart
reviewed
Oct 26, 2023
| @@ -448,7 +446,13 @@ local init_splash = true | |||
| local append_bootargs = "" | |||
| local append_init = "" | |||
| local append_entrypoint = "" | |||
| local rollup | |||
| local rollup = { | |||
There was a problem hiding this comment.
This only solves for cartesi-machine.lua, what about the C API cm_get_default_config ? Shoudn't we also make this the default there? cc @diegonehab
There was a problem hiding this comment.
Yes. It should be default in C++ as well.
There was a problem hiding this comment.
We do not get the default config in cartesi-machine.lua, right? We build one from scracth. Should we stop doing that?
There was a problem hiding this comment.
Victor will create an issue about 'get_default_config' vs. 'cartesi-machine.lua'
vfusco
force-pushed
the
feature/rollup-default
branch
3 times, most recently
from
e4e0ec5 to
0bca727
Compare
vfusco
force-pushed
the
feature/rollup-default
branch
from
0bca727 to
e6fb69f
Compare
edubart
requested changes
Oct 30, 2023
vfusco
force-pushed
the
feature/rollup-default
branch
from
e6fb69f to
f1c9860
Compare
diegonehab
approved these changes
Oct 30, 2023
edubart
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #102