-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PostgreSQL bindings available in Python3 #3
base: master
Are you sure you want to change the base?
Conversation
I believe the lines deleted were added by mistake (perhaps when coding in Vim)
…tion returns error. Add socket_recv() function in addition to socket_send()
…ffer. Simplify FIX::integer_to_string_padded() function by making width parameter equal to len. Code cleanup
…stances of the groups with corresponding tag. Consider renaming this function to removeAllGroups()
…essage exception when data length field is not found.
…when data field length contains junk. Resolves issue with GarbledMessage acceptance test cases.
… to swig. Disable uninitialized warnings in swig since we can't control that code.
…aropawil-master Conflicts: configure.ac src/C++/DataDictionary.cpp src/C++/DataDictionary.h src/C++/Field.h src/C++/FieldConvertors.h src/C++/FieldMap.h src/C++/FieldTypes.cpp src/C++/FieldTypes.h src/C++/SessionSettings.h src/C++/Utility.h
If you want to see just my changes, take a look at c572fd0 |
Any word on this? Let me know if you need any other info or if you have any questions. |
@joncinque We have a few internal things we're working on that are taking precedent over testing this on staging (our first pass at it appears ok though). We will update you once we have a chance to thoroughly test it. thanks! |
Ok cool, thanks for the update! |
Any update here? |
Will likely be a few more weeks |
@joncinque We've begun testing this on a staging environment. Will likely keep that going for a few more weeks before deploying. Will keep you updated! |
Great, let me know if you need anything more! |
Has this been integrated? Do you still need this branch and repo for your tests? |
And also, do you want to make a pull request to the main quickfix to expose these postgres bindings? |
I need to integrate some changes back to the original quickfix, and since github only allows one fork of a project per account, I'd like to get rid of this one to have it point to the original quickfix. I've made a local clone with a branch of the PostgreSQL changes on top of the canonical repo. If I don't hear from you otherwise by Monday, I'll go ahead and remove this fork in order to work against the main quickfix repo. Let me know how you want to proceed. |
This pull request contains a lot of changes to update the carta fork to the current quickfix master. To make it easier to see my contributions compared with what everyone else has done, I will separately push my changes.
To build:
New test case has been provided at
src/python/test/PostgreSQLStoreTestCase.py
which simply translatessrc/C++/test/PostgreSQLStoreTestCase.cpp
. Note that it is not run by default fromsrc/python/test-python*.sh
.To run the test, modify
PostgreSQLStoreTestCase.py
to add in your appropriate testing configuration (DB name, user, password, etc), then let it rip!IMPORTANT NOTE: some of the test cases drop the tables, so BE SURE to use a testing database.
Let me know if you have any questions or concerns.