fix some more pmd warnings

carstenartur · Aug 25, 2024 · 7b89c83 · 7b89c83
1 parent a0b9c88
commit 7b89c83
Show file tree

Hide file tree

Showing 12 changed files with 11 additions and 34 deletions.
diff --git a/sandbox_common/src/org/sandbox/jdt/internal/common/ReferenceHolder.java b/sandbox_common/src/org/sandbox/jdt/internal/common/ReferenceHolder.java
@@ -36,12 +36,6 @@ public class ReferenceHolder<V,T> extends ConcurrentHashMap<V,T> implements Help
 	private static final long serialVersionUID = 1L;
 	HelperVisitor<ReferenceHolder<V,T>,V,T> hv;
 
-	/**
-	 *
-	 */
-	public ReferenceHolder() {
-	}
-
 	@Override
 	public HelperVisitor<ReferenceHolder<V,T>,V,T> getHelperVisitor() {
 		return hv;

diff --git a/sandbox_extra_search/src/org/sandbox/jdt/internal/ui/search/OpenUpdateSearchPageAction.java b/sandbox_extra_search/src/org/sandbox/jdt/internal/ui/search/OpenUpdateSearchPageAction.java
@@ -32,9 +32,6 @@ public class OpenUpdateSearchPageAction implements IWorkbenchWindowActionDelegat
 
 	private IWorkbenchWindow fWindow;
 
-	public OpenUpdateSearchPageAction() {
-	}
-
 	@Override
 	public void init(IWorkbenchWindow window) {
 		fWindow= window;

diff --git a/sandbox_jface_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/JFacePlugin.java b/sandbox_jface_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/JFacePlugin.java
@@ -72,7 +72,7 @@
  * doSomeMoreWork(subMonitor.split(40)); }
  */
 public class JFacePlugin extends
-AbstractTool<ReferenceHolder<Integer, org.sandbox.jdt.internal.corext.fix.helper.JFacePlugin.MonitorHolder>> {
+AbstractTool<ReferenceHolder<Integer, JFacePlugin.MonitorHolder>> {
 
 	public static final String CLASS_INSTANCE_CREATION = "ClassInstanceCreation"; //$NON-NLS-1$
 	public static final String METHODINVOCATION = "MethodInvocation"; //$NON-NLS-1$

diff --git a/sandbox_jface_cleanup_test/src/org/sandbox/jdt/ui/tests/quickfix/Java8CleanUpTest.java b/sandbox_jface_cleanup_test/src/org/sandbox/jdt/ui/tests/quickfix/Java8CleanUpTest.java
@@ -103,7 +103,8 @@ public void createPackageFragmentRoot2(IProgressMonitor monitor) throws CoreExce
 					}
 					"""); //$NON-NLS-1$
 
-		String given, expected;
+		String given;
+		String expected;
 
 		JFaceCleanupCases(String given, String expected) {
 			this.given=given;

diff --git a/sandbox_platform_helper_test/src/org/sandbox/jdt/ui/tests/quickfix/Java8CleanUpTest.java b/sandbox_platform_helper_test/src/org/sandbox/jdt/ui/tests/quickfix/Java8CleanUpTest.java
@@ -124,12 +124,13 @@ public class E1 {
 						IStatus status = new Status(IStatus.INFO, "plugin id", "important message", null);
 					}"""); //$NON-NLS-1$
 
+		String given;
+		String expected;
+
 		PlatformStatusPatterns(String given, String expected) {
 			this.given=given;
 			this.expected=expected;
 		}
-
-		String given, expected;
 	}
 
 	@ParameterizedTest

diff --git a/sandbox_tools_test/src/org/sandbox/jdt/ui/tests/quickfix/Java8CleanUpTest.java b/sandbox_tools_test/src/org/sandbox/jdt/ui/tests/quickfix/Java8CleanUpTest.java
@@ -325,7 +325,8 @@ void m(List<PropertyResourceBundle> bundles) {
 								+ "}\n" //$NON-NLS-1$
 								+ ""); //$NON-NLS-1$
 
-		String given, expected;
+		String given;
+		String expected;
 
 		While2EnhancedForLoop(String given, String expected) {
 			this.given=given;

diff --git a/sandbox_usage_view/src/org/sandbox/jdt/ui/helper/views/colum/DeclaringMethodColumn.java b/sandbox_usage_view/src/org/sandbox/jdt/ui/helper/views/colum/DeclaringMethodColumn.java
@@ -22,9 +22,6 @@ public class DeclaringMethodColumn extends AbstractColumn {
 	private static final int bounds= 100;
 	private static final String title= "DeclaringMethod"; //$NON-NLS-1$
 
-	public DeclaringMethodColumn() {
-	}
-
 	@Override
 	public void createColumn(TableViewer viewer, int pos) {
 		// now the DeclaringMethod

diff --git a/sandbox_usage_view/src/org/sandbox/jdt/ui/helper/views/colum/DeprecatedColumn.java b/sandbox_usage_view/src/org/sandbox/jdt/ui/helper/views/colum/DeprecatedColumn.java
@@ -22,9 +22,6 @@ public class DeprecatedColumn extends AbstractColumn {
 	private static final int bounds= 100;
 	private static final String title= "Deprecated"; //$NON-NLS-1$
 
-	public DeprecatedColumn() {
-	}
-
 	@Override
 	public void createColumn(TableViewer viewer, int pos) {
 		// now the deprecated or not checkbox

diff --git a/sandbox_usage_view/src/org/sandbox/jdt/ui/helper/views/colum/PackageColumn.java b/sandbox_usage_view/src/org/sandbox/jdt/ui/helper/views/colum/PackageColumn.java
@@ -23,9 +23,6 @@ public class PackageColumn extends AbstractColumn {
 	private static final int bounds= 100;
 	private static final String title= "Class and Package"; //$NON-NLS-1$
 
-	public PackageColumn() {
-	}
-
 	@Override
 	public void createColumn(TableViewer viewer, int pos) {
 		// now the class you find the variable

diff --git a/sandbox_usage_view/src/org/sandbox/jdt/ui/helper/views/colum/QualifiednameColumn.java b/sandbox_usage_view/src/org/sandbox/jdt/ui/helper/views/colum/QualifiednameColumn.java
@@ -21,9 +21,6 @@ public class QualifiednameColumn extends AbstractColumn {
 	private static final int bounds= 100;
 	private static final String title= "Type"; //$NON-NLS-1$
 
-	public QualifiednameColumn() {
-	}
-
 	@Override
 	public void createColumn(TableViewer viewer, int pos) {
 		// Second column is for the type

diff --git a/sandbox_xml_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/XMLCandidateHit.java b/sandbox_xml_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/XMLCandidateHit.java
@@ -19,10 +19,4 @@ public class XMLCandidateHit {
 
 	public ASTNode whileStatement;
 
-	/**
-	 *
-	 */
-	public XMLCandidateHit() {
-	}
-
 }
diff --git a/sandbox_xml_cleanup_test/src/org/sandbox/jdt/ui/tests/quickfix/Java8CleanUpTest.java b/sandbox_xml_cleanup_test/src/org/sandbox/jdt/ui/tests/quickfix/Java8CleanUpTest.java
@@ -58,12 +58,13 @@ void m() {
 					}
 					""");
 
+		String given;
+		String expected;
+
 		XMLCleanupCases(String given, String expected) {
 			this.given=given;
 			this.expected=expected;
 		}
-
-		String given, expected;
 	}
 
 	@Disabled
-Original file line number
+Diff line change
@@ Expand Up / @@ -19,10 +19,4 @@ public class XMLCandidateHit { @@
     	public ASTNode whileStatement;
-    	/**
-    	 *
-    	 */
-    	public XMLCandidateHit() {
-    	}
     }