some more pmd warnings

carstenartur · Aug 25, 2024 · 153ee92 · 153ee92
1 parent f3d21c9
commit 153ee92
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/sandbox_cleanup_application/src/org/sandbox/jdt/core/cleanupapp/CodeCleanupApplication.java b/sandbox_cleanup_application/src/org/sandbox/jdt/core/cleanupapp/CodeCleanupApplication.java
@@ -213,8 +213,6 @@ private File[] processCommandLine(String[] argsArray) {
 			String currentArg = argsArray[index++];
 
 			switch(mode) {
-				default:
-					break;
 				case DEFAULT_MODE :
 					if (PDE_LAUNCH.equals(currentArg)) {
 						continue loop;
@@ -265,6 +263,8 @@ private File[] processCommandLine(String[] argsArray) {
 					}
 					mode = DEFAULT_MODE;
 					continue loop;
+				default:
+					break;
 			}
 		}
 

diff --git a/sandbox_tools_test/src/org/sandbox/jdt/ui/tests/quickfix/VisitorTest.java b/sandbox_tools_test/src/org/sandbox/jdt/ui/tests/quickfix/VisitorTest.java
@@ -550,7 +550,7 @@ public void simpleTest5d() {
 	@Test
 	public void simpleTest5e() {
 		ReferenceHolder<ASTNode, Map<String,Object>> dataholder = new ReferenceHolder<>();
-		HelperVisitor.callVariableDeclarationStatementVisitor(Iterator.class, cunit2, dataholder,null, (init_iterator,holder_a)->{
+		HelperVisitor.callVariableDeclarationStatementVisitor(Iterator.class, cunit2, dataholder,null, (init_iterator,holdera)->{
 			List<String> computeVarName = computeVarName(init_iterator);
 			HelperVisitor.callWhileStatementVisitor(init_iterator.getParent(), dataholder,null, (whilestatement,holder)->{
 				String name = computeNextVarname(whilestatement);
@@ -617,7 +617,7 @@ private static List<String> computeVarName(VariableDeclarationStatement node_a)
 		if (exp instanceof MethodInvocation mi) {
 			Expression element = mi.getExpression();
 			if (element instanceof SimpleName sn) {
-				if (mi.getName().toString().equals("iterator")) { //$NON-NLS-1$
+				if ("iterator".equals(mi.getName().toString())) { //$NON-NLS-1$
 					name.add(sn.getIdentifier());
 				}
 			}

diff --git a/sandbox_usage_view/src/org/sandbox/jdt/ui/helper/views/JavaHelperView.java b/sandbox_usage_view/src/org/sandbox/jdt/ui/helper/views/JavaHelperView.java
@@ -448,7 +448,7 @@ public boolean show(ShowInContext context) {
 						input.add(item);
 					}
 				}
-				if (input.size() > 0) {
+				if (!input.isEmpty()) {
 					setInput(input);
 					return true;
 				}