Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package requirements according to CRAN comments #141

Merged
merged 3 commits into from
Feb 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions R/utils.R
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ recode_sex <- function(input_data,
#' @rawNamespace import(tidyr, except = extract)
#' @rawNamespace import(dplyr, except = c(last, first, summarize, src, between))
#' @examples
#' \donttest{
#' # Run on a small subset of given data
#' df <- as.data.frame(syngrowth)
#' df <- df[df$subjid %in% unique(df[, "subjid"])[1:2], ]
Expand All @@ -193,6 +194,7 @@ recode_sex <- function(input_data,
#'
#' # Specify all inclusion codes
#' wide_df <- longwide(df, inclusion_types = c("Include", "Exclude-Carried-Forward"))
#' }
longwide <-
function(long_df,
id = "id",
Expand Down Expand Up @@ -329,6 +331,7 @@ longwide <-
#' @import data.table
#' @rawNamespace import(dplyr, except = c(last, first, summarize, src, between))
#' @examples
#' \donttest{
#' # Simple usage
#' # Run on a small subset of given data
#' df <- as.data.frame(syngrowth)
Expand All @@ -347,6 +350,7 @@ longwide <-
#' colnames(wide_df)[colnames(wide_df) %in% c("wt", "ht")] <-
#' c("weight", "height")
#' wide_df_with_bmi <- simple_bmi(wide_df, wtcol = "weight", htcol = "height")
#' }
simple_bmi <- function(wide_df, wtcol = "wt", htcol = "ht") {
# Verify the specified columns are present
if (!all(c(wtcol, htcol) %in% colnames(wide_df))) {
Expand Down
43 changes: 41 additions & 2 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,44 @@
# CRAN submission growthcleanr 2.2.0 (2)

## R CMD check results
There were no ERRORs or WARNINGs.

There was one NOTE:

❯ checking installed package size ... NOTE
installed size is 5.9Mb
sub-directories of 1Mb or more:
extdata 5.0Mb

extdata has been compressed as much as possible -- data in that folder is necessary to run the package.

## Downstream dependencies
There are currently no downstream dependencies for this package.

## CRAN test

We have addressed each of the notes in the test as noted below:

* Maintainer: 'Carrie Daymont <[email protected]>'

Size of tarball: 5529566 bytes

The package has been compressed as much as possible, as noted above -- data included is necessary to run the package.

* NOTE
Examples with CPU (user + system) or elapsed time > 5s
user system elapsed
simple_bmi 6.542 0.218 0.622
longwide 6.344 0.230 0.858
Examples with CPU time > 2.5 times elapsed time
user system elapsed ratio
simple_bmi 6.542 0.218 0.622 10.868
longwide 6.344 0.230 0.858 7.662

Examples have been set to donttest.

# Previous Submissions

# CRAN submission growthcleanr 2.2.0 (1)

## R CMD check results
Expand Down Expand Up @@ -47,8 +88,6 @@ Running R code in ‘testthat.R’ had CPU time 3.1 times elapsed time

Tests have been set to not run on CRAN.

# Previous Submissions

# CRAN submission growthcleanr 2.2.0

## R CMD check results
Expand Down
2 changes: 1 addition & 1 deletion docs/articles/adult-algorithm.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/articles/configuration.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/articles/developer-guidelines.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/articles/installation.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/articles/large-data-sets.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/articles/next-steps.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/articles/output.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/articles/prelim-infants-algorithm.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/articles/quickstart.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/articles/usage.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/articles/utilities.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/pkgdown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ articles:
quickstart: quickstart.html
usage: usage.html
utilities: utilities.html
last_built: 2023-09-15T16:20Z
last_built: 2024-02-05T13:40Z

4 changes: 3 additions & 1 deletion docs/reference/longwide.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion docs/reference/simple_bmi.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions man/longwide.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions man/simple_bmi.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.