Add support for site with translations #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like the ubuntu image for the checks is too old, not sure if I can do something about that. Have tested these changes locally though and they seem to work. |
This kind of hackily supports translations for footer_links/tagline.
An example of how that might look when you've got english and russian
translations:
[extra]
[extra.footer_tagline]
en = "English tagline"
ru = "Russian tagline"
[extra.footer_links]
en = [{url = "$BASE_URL/about", name = "English about"}]
ru = [{url = "$BASE_URL/about", name = "Russian about"}]
If this isn't needed the old way that the readme describes still works,
then the same values are use independently of the language on the rest
of the page. The $BASE_URL in the links above will change depending on
the current language.
The 'title' and 'description' items should be placed in [translations]
and [languages.XX] as described by the Zola guide.
lfxgroove
force-pushed
the
add_translation_support
branch
from
8d18e12 to
4d7075b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This kind of hackily supports translations for footer_links/tagline. An example of how that might look when you've got english and russian translations:
If this isn't needed the old way that the readme describes still works, then the same values are use independently of the language on the rest of the page. The
$BASE_URLin the links above will change depending on the current language.The 'title' and 'description' items should be placed in
[translations]and[languages.XX]as described by the Zola guide.