WIP: Multi successtag #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 3, 2017 08:30
allow for multiple success tags by specifying the option more that once TODO: documentation of function
wfailla
commented
Jul 3, 2017
| @@ -124,9 +124,10 @@ def set_commitfailures(self, cf): | |||
| """ | |||
| self.commit_failures = cf | |||
|
|
|||
| def set_success_tag(self, repo): | |||
| def append_success_tag(self, tag): | |||
There was a problem hiding this comment.
Change tag to some thing that will not be confused with repo:TAG.
wfailla
commented
Jul 3, 2017
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/python | |||
| #!/usr/bin/env python2 | |||
There was a problem hiding this comment.
Move to different MR
wfailla
commented
Jul 3, 2017
| @@ -75,7 +76,7 @@ def main(argv): | |||
| ["help", "checkout", "dry-run", "images", "skip-failure-commit", | |||
| "list=", "list-bids", "entry=", "target=", "match-build-id", | |||
| "new-build-id=", "upgrade=", "append-local-conf=", "success-tag="]) | |||
| except getopt.GetoptError, e: | |||
| except getopt.GetoptError as e: | |||
There was a problem hiding this comment.
Move to different MR
wfailla
commented
Jul 3, 2017
| @@ -98,7 +99,8 @@ def main(argv): | |||
| elif opt in ['-F', '--skip-failure-commit']: | |||
| redo.set_commitfailures(False) | |||
| elif opt in ['--success-tag']: | |||
| redo.set_success_tag(arg) | |||
| # change to multiple --success-tag calls | |||
| redo.append_success_tag(arg.split) | |||
There was a problem hiding this comment.
remove faulty .split
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add the functionality that multiple success tags are passed as parameter:
As requested in #7 .