Do not assume that lack of data-currency attribute means element is formatted in oldCurrency #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…element is in oldCurrency format.
|
I've only included currencies.liquid to help anybody that is trying to fix the exact same issue. |
ghost
mentioned this pull request
|
Hi andymurph. I added both the changed currencies.liquid and js files. My currency selector is disabled. It shows all prices in the ZAR store base currency, but I can't change currency. I trawled the code but couldnt find where i missed anything. Am i supposed to hardcode a base currency or alternate currency into the liquid file? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how I would resolve #8 .