Firmware updater which provides Firmware update progress #159
Conversation
psmithcrl
requested review from
mattalvarado,
QuentinTorg,
jyakubik and
dougbalish1
…to psmithcrl/FirmwareUpdateProgress
|
Does it make sense to remove this outdated flash utility at the same time? https://github.com/carnegierobotics/LibMultiSense/tree/master/source/Utilities/FlashUtility |
@QuentinTorg |
|
#164 first |
| int main(int argc, char *argv[]) { | ||
|
|
||
| char IpAddress[INET_ADDRSTRLEN] = {}; | ||
| char FilePath[PATH_MAX] = {}; |
There was a problem hiding this comment.
Can we use a std::string here?
|
|
||
| } | ||
|
|
||
| int Ip::Setup(const char * _IpAddress) |
There was a problem hiding this comment.
Should we just use std::string instead of the c alternative?
| sent = Send((uint8_t*)&Block, sizeof(Block)); | ||
| if (sent!=sizeof(Block)) | ||
| { | ||
| std::cerr << "RUNT Sent Expected " << l << " Got " << sent << std::endl; |
There was a problem hiding this comment.
Should we clean up this print?
| } | ||
| crc32_final = crc32_initial; | ||
|
|
||
| std::cout << "CRC32 0x" << std::hex << crc32_final << std::endl; |
There was a problem hiding this comment.
Is this print necessary?
| if (!FilePath) | ||
| { | ||
| std::cerr << "Invalid File\n"; | ||
| return -1; | ||
| } | ||
|
|
||
| int fd = open(FilePath, O_RDONLY|O_SYNC); | ||
| if (fd < 0){ | ||
| std::cerr << "Failed to open file!\n"; | ||
| return -1; | ||
| } | ||
|
|
||
| uint32_t FileSize = lseek(fd, 0L, SEEK_END); | ||
| lseek(fd, 0L, SEEK_SET); |
There was a problem hiding this comment.
Should you use a std::ifstream here?
* Fix windows build (#158) * add instance of static member of Timestamp, for windows_build * fix for visual studio warning * Add CI build (#162) * add github action for building libmultisense * fix one header before move to windows machine * update some dead links * builds on ubuntu, not tested * test windows commit * Dbalish/windows buildfix (#163) * reorder includes so min/max macros don't get defined * remove accidental newline * WIP * add windows style struct packing * make message values unsigned * builds in windows - untested * windows build tested and working * fix broken #defines * last bit of cleanpup --------- Co-authored-by: hshibatacrl <[email protected]> Co-authored-by: Quentin Torgerson <[email protected]>
Please test this out and provide some feedback.
This will bind to a server process running on the camera.
Will update to include which firmware versions are compatible with this update process.