Use async/await for pokemon-client #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx for the PR. And you are right I could change the "description" function in a similar way. 👍 |
carlosvillu
added a commit
that referenced
this pull request
Jul 13, 2015
Use async/await for pokemon-client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(to continue discussion from essential-react at the proper place)
The
pokemonfunction could process with async/await and manipulate variables instead of subscribing to promises since it does return a promise.Another thing in the same file could be to remove async from
descriptionsmethod since it could synchronously return an array of promises instead of a promise which immediately resolves to an array of promises. Did not perform the change because it would change the return type and has effects on other parts of the code.