Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build(deps): bump actions/{up, down}load-artifact from 3 to 4" #1561

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Revert "build(deps): bump actions/{up, down}load-artifact from 3 to 4" #1561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ jobs:
# Set working directory here, otherwise `cargo-zigbuild` would download
# and build quite a few unused dependencies.
working-directory: crates/detect-targets
- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v3
with:
name: detect-targets
path: target/${{ env.CARGO_BUILD_TARGET }}/debug/detect-targets
Expand All @@ -183,7 +183,7 @@ jobs:
steps:
- uses: actions/checkout@v4

- uses: actions/download-artifact@v4
- uses: actions/download-artifact@v3
with:
name: detect-targets
- run: chmod +x detect-targets
Expand All @@ -205,7 +205,7 @@ jobs:
- ubuntu-latest
runs-on: ${{ matrix.os }}
steps:
- uses: actions/download-artifact@v4
- uses: actions/download-artifact@v3
with:
name: detect-targets
- run: chmod +x detect-targets
Expand All @@ -228,7 +228,7 @@ jobs:
- fedora
runs-on: ubuntu-latest
steps:
- uses: actions/download-artifact@v4
- uses: actions/download-artifact@v3
with:
name: detect-targets
- run: chmod +x detect-targets
Expand All @@ -244,7 +244,7 @@ jobs:
needs: detect-targets-build
runs-on: ubuntu-latest
steps:
- uses: actions/download-artifact@v4
- uses: actions/download-artifact@v3
with:
name: detect-targets
- run: chmod +x detect-targets
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/release-cli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ jobs:
env:
AGE_KEY_PUBLIC: ${{ vars.AGE_KEY_PUBLIC }}
run: .github/scripts/ephemeral-gen.sh
- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v3
with:
name: minisign.pub
path: minisign.pub
- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v3
with:
name: minisign.key.age
path: minisign.key.age
Expand Down Expand Up @@ -79,7 +79,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/download-artifact@v4
- uses: actions/download-artifact@v3
with:
name: minisign.pub

Expand All @@ -93,7 +93,7 @@ jobs:
run: cargo publish --dry-run -p "$crate" --allow-dirty --no-default-features
- if: fromJSON(inputs.info).is-release != 'true' && fromJSON(inputs.info).crate != ''
name: Upload crate package as artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
with:
name: crate-package
path: target/package/*.crate
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/release-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:

- run: just toolchain rust-src

- uses: actions/download-artifact@v4
- uses: actions/download-artifact@v3
with:
name: minisign.pub
- run: just package
Expand All @@ -85,7 +85,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- uses: actions/download-artifact@v4
- uses: actions/download-artifact@v3
with:
name: minisign.key.age
- name: Sign package
Expand All @@ -107,14 +107,14 @@ jobs:
prerelease: true
- if: "fromJSON(inputs.publish).is-release != 'true' || runner.os == 'macOS'"
name: Upload artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
with:
name: ${{ matrix.t }}
path: packages/cargo-binstall-*
retention-days: 1

- name: Upload timings
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
with:
name: ${{ matrix.t }}-cargo-timings
path: target/cargo-timings
Expand All @@ -138,27 +138,27 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- uses: actions/download-artifact@v4
- uses: actions/download-artifact@v3
with:
name: x86_64h-apple-darwin
path: packages/
- uses: actions/download-artifact@v4
- uses: actions/download-artifact@v3
with:
name: x86_64-apple-darwin
path: packages/
- uses: actions/download-artifact@v4
- uses: actions/download-artifact@v3
with:
name: aarch64-apple-darwin
path: packages/

- uses: actions/download-artifact@v4
- uses: actions/download-artifact@v3
with:
name: minisign.pub
- run: ls -shalr packages/
- run: just repackage-lipo
- run: ls -shal packages/

- uses: actions/download-artifact@v4
- uses: actions/download-artifact@v3
with:
name: minisign.key.age
- env:
Expand All @@ -180,7 +180,7 @@ jobs:
prerelease: true
- if: fromJSON(inputs.publish).is-release != 'true'
name: Upload artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
with:
name: universal-apple-darwin
path: packages/cargo-binstall-universal-*
Expand Down