Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some pending tests #1778

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Remove some pending tests #1778

merged 2 commits into from
Jan 9, 2025

Conversation

noonio
Copy link
Contributor

@noonio noonio commented Jan 8, 2025

Two small changes:

  • Remove some pendingWith calls that were just invalid
  • Switch some xit to it statements for things that were presently already working, but for some reason we were expecting them not to.

Copy link

github-actions bot commented Jan 8, 2025

Transaction cost differences

No cost or size differences found

Copy link

github-actions bot commented Jan 8, 2025

Transaction costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2025-01-08 15:36:40.875139097 UTC
Max. memory units 14000000
Max. CPU units 10000000000
Max. tx size (kB) 16384

Script summary

Name Hash Size (Bytes)
νInitial 00a6ddbc130ab92f5b7cb8d1ccd8d79eca5bfe25f6843c07b62841f0 2667
νCommit 3e5a776bcee213e3dfd15806952a10ac5590e3e97d09d62eb99266b2 690
νHead 5350e9d521552ebfd9e846fd70c3b801f716fc14296134ec0fb71e97 14495
μHead 482c3ce15cde05bc905b915ccfa2546e500be1c5d722389026c37aa3* 5615
νDeposit de09cec5f84eedaf64186cb52ba4ee6e74e6fc368af25b90d457f352 1118
  • The minting policy hash is only usable for comparison. As the script is parameterized, the actual script is unique per head.

Init transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 6165 10.17 3.24 0.53
2 6365 12.04 3.82 0.56
3 6564 14.09 4.46 0.59
5 6966 18.67 5.93 0.65
10 7975 28.90 9.15 0.80
44 14810 98.04 30.85 1.82

Commit transaction costs

This uses ada-only outputs for better comparability.

UTxO Tx size % max Mem % max CPU Min fee ₳
1 561 2.45 1.17 0.20
2 742 3.40 1.74 0.22
3 922 4.39 2.34 0.24
5 1275 6.46 3.61 0.28
10 2177 12.24 7.28 0.40
54 10066 99.20 68.72 1.89

CollectCom transaction costs

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 57 525 24.20 7.07 0.42
2 114 636 31.94 9.30 0.50
3 171 747 40.85 11.84 0.60
4 225 858 53.25 15.18 0.73
5 283 969 60.38 17.27 0.81
6 339 1085 74.88 21.20 0.96
7 396 1192 86.80 24.51 1.08
8 452 1303 91.38 25.96 1.13

Cost of Increment Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 1814 24.13 8.02 0.48
2 1960 25.09 9.04 0.50
3 2136 28.04 10.67 0.55
5 2390 31.21 13.05 0.60
10 3213 40.07 19.39 0.76
41 7935 99.27 59.65 1.73

Cost of Decrement Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 601 22.72 7.32 0.41
2 767 23.39 8.17 0.43
3 975 28.02 10.14 0.49
5 1172 28.95 11.72 0.52
10 2079 40.20 18.22 0.70
41 6820 98.81 55.34 1.65

Close transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 677 27.03 8.73 0.46
2 882 29.29 10.22 0.50
3 1089 31.39 11.66 0.54
5 1266 34.05 13.71 0.58
10 1911 45.13 20.45 0.75
38 6338 95.70 56.50 1.61

Contest transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 674 33.39 10.43 0.52
2 799 35.38 11.70 0.56
3 1012 37.74 13.22 0.59
5 1330 42.38 16.07 0.67
10 1982 52.29 22.49 0.82
32 5301 99.89 52.65 1.57

Abort transaction costs

There is some variation due to the random mixture of initial and already committed outputs.

Parties Tx size % max Mem % max CPU Min fee ₳
1 6051 26.05 8.82 0.69
2 6175 34.66 11.71 0.79
3 6275 43.41 14.66 0.88
4 6468 52.03 17.69 0.98
5 6686 63.38 21.54 1.11
6 6684 70.86 23.95 1.19
7 6834 77.22 26.15 1.26
8 6941 86.20 29.11 1.36
9 7161 98.34 33.42 1.50

FanOut transaction costs

Involves spending head output and burning head tokens. Uses ada-only UTXO for better comparability.

Parties UTxO UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
10 0 0 6162 18.03 6.15 0.61
10 1 57 6197 19.99 6.94 0.63
10 5 285 6332 27.25 9.88 0.72
10 10 569 6501 37.40 13.95 0.84
10 30 1708 7182 77.15 29.92 1.31
10 40 2276 7520 95.81 37.45 1.53
10 41 2332 7553 97.25 38.05 1.54

End-to-end benchmark results

This page is intended to collect the latest end-to-end benchmark results produced by Hydra's continuous integration (CI) system from the latest master code.

Please note that these results are approximate as they are currently produced from limited cloud VMs and not controlled hardware. Rather than focusing on the absolute results, the emphasis should be on relative results, such as how the timings for a scenario evolve as the code changes.

Generated at 2025-01-08 15:39:28.656240309 UTC

Baseline Scenario

Number of nodes 1
Number of txs 300
Avg. Confirmation Time (ms) 4.327407816
P99 11.21693671999998ms
P95 5.056102750000001ms
P50 4.1193825ms
Number of Invalid txs 0

Three local nodes

Number of nodes 3
Number of txs 900
Avg. Confirmation Time (ms) 24.201909395
P99 116.8438116ms
P95 33.2123075ms
P50 21.697401ms
Number of Invalid txs 0

Copy link

github-actions bot commented Jan 8, 2025

Test Results

  5 files  ±0  165 suites  ±0   30m 36s ⏱️ -5s
563 tests ±0  561 ✅ +4  2 💤  - 4  0 ❌ ±0 
565 runs  ±0  563 ✅ +4  2 💤  - 4  0 ❌ ±0 

Results for commit 8fd0f27. ± Comparison against base commit 2039d7c.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.
Hydra.Options/Hydra Node RunOptions/publish-scripts sub-command ‑ does not parse with some missing option (1)
Hydra.Options/Hydra Node RunOptions/publish-scripts sub-command ‑ does not parse with some missing option (2)
Hydra.Options/Hydra Node RunOptions/publish-scripts sub-command ‑ does not parse with some missing option (3)
Hydra.Options/Hydra Node RunOptions/publish-scripts sub-command ‑ does not parse without any options
Hydra.Options/Hydra Node RunOptions/publish-scripts sub-command ‑ parses with some missing option (1)
Hydra.Options/Hydra Node RunOptions/publish-scripts sub-command ‑ parses with some missing option (2)
Hydra.Options/Hydra Node RunOptions/publish-scripts sub-command ‑ parses with some missing option (3)
Hydra.Options/Hydra Node RunOptions/publish-scripts sub-command ‑ parses without any options

♻️ This comment has been updated with latest results.

@noonio noonio requested a review from a team January 8, 2025 15:16
@noonio noonio force-pushed the remove-some-pending-tests branch from 736993c to 8fd0f27 Compare January 8, 2025 15:34
@locallycompact locallycompact added this pull request to the merge queue Jan 9, 2025
Merged via the queue into master with commit 1fc5257 Jan 9, 2025
27 checks passed
@locallycompact locallycompact deleted the remove-some-pending-tests branch January 9, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants