[ADP-3479] Add input bip32 list to Transaction type #4866
Merged
+134
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolino
changed the title
paolino
force-pushed
the
paolino/ADP-3479/amend-wallet-page-to-host-wallet-status
branch
from
6c6d79a to
d0a4d38
Compare
paolino
force-pushed
the
paolino/ADP-3479/add-bip32-paths-to-unsigned-and-signed-tx-serialization
branch
from
6a21e81 to
4b3cfac
Compare
paolino
force-pushed
the
paolino/ADP-3479/amend-wallet-page-to-host-wallet-status
branch
from
d0a4d38 to
ec9bd83
Compare
paolino
force-pushed
the
paolino/ADP-3479/add-bip32-paths-to-unsigned-and-signed-tx-serialization
branch
from
4b3cfac to
c95fe11
Compare
abailly
reviewed
Dec 9, 2024
There was a problem hiding this comment.
I think we need a roundtrip property test for BIP32Path <-> JSON encoding, and I would add the decodeBip32/encodeBIP32 as proper FromJSON/ToJSON instances to the BIP32Path. With ToJSON/FromJSON/Arbitrary instances available, we can leverage hspec-golden-aeson to add standard tests.
Base automatically changed from
paolino/ADP-3479/amend-wallet-page-to-host-wallet-status
to
paolino/ADP-3479/add-payment-page
December 9, 2024 16:32
abailly
force-pushed
the
paolino/ADP-3479/add-payment-page
branch
from
5718b41 to
8f6fd06
Compare
abailly
force-pushed
the
paolino/ADP-3479/add-bip32-paths-to-unsigned-and-signed-tx-serialization
branch
2 times, most recently
from
4a39c7b to
3a17e87
Compare
abailly
force-pushed
the
paolino/ADP-3479/add-bip32-paths-to-unsigned-and-signed-tx-serialization
branch
from
3a17e87 to
1718456
Compare
The ToJSON/FromJSON/Arbitrary instances for BIP32Path should probably live alongside the corresponding datatype definition but it's good enough for now. Interestingly, writing the property showed a bug: The parsing of `Root` path was incorrect!
abailly
force-pushed
the
paolino/ADP-3479/add-bip32-paths-to-unsigned-and-signed-tx-serialization
branch
from
1718456 to
407f32c
Compare
abailly
deleted the
paolino/ADP-3479/add-bip32-paths-to-unsigned-and-signed-tx-serialization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADP-3479