[ADP-3488] Add unit tests for mapping from XPub to Address
#4859
+210
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3488/key-tests
branch
from
2b82205 to
2cbc7f9
Compare
paolino
approved these changes
Nov 28, 2024
lib/customer-deposit-wallet/test/unit/Cardano/Wallet/Deposit/Write/KeysSpec.hs
Outdated
Show resolved
Hide resolved
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3488/key-tests
branch
from
2cbc7f9 to
83c3c80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds unit tests for
XPub→AddressXSignatureby comparing
Cardano.Wallet.Address.Encodingagainst the implementation inCardano.Ledger.We adopt the fix of the mapping
XPub→Addressby adjusting to the latest version of thecardano-wallet-agdarepository.Issue Number
ADP-3488