Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADP-3486] Add a simple bash script to generate random deposit payments #4857

Merged
merged 14 commits into from
Dec 6, 2024

Conversation

abailly
Copy link
Collaborator

@abailly abailly commented Nov 22, 2024

See the script's usage for details. This PR is in draft because I think the script is wrong: The wallet is not able to detect payment transactions it's making.

@abailly
Copy link
Collaborator Author

abailly commented Nov 22, 2024

So I was able to run the script and generating a transaction with 22 outputs paying to a random set of accounts between 0 and 10. The old wallet API shows the transaction correctly but the deposit wallet's API does not. /cc @paolino

@abailly abailly marked this pull request as ready for review November 22, 2024 15:50
@abailly abailly requested review from Anviking and paolino November 22, 2024 15:51
@abailly
Copy link
Collaborator Author

abailly commented Nov 29, 2024

Following changes introduced in #4863 we were able to observe deposit transactions' outputs in the wallet's UI which means the deposit wallet's address derivation matches cardano-addresses'

Also add some documentation showing output of the script.
Without the quotes, the body of the here document is interpreted by
the shell potentially leading to all kind of weird behaviour.
Also output the total remaining UTxO value from accumulated deposit
payments. These 2 features together are useful to create chained
transactions without having to wait for one to be submitted.
This makes it possible to use a large UTxO in smaller chunks
@abailly abailly force-pushed the abailly/demo-wallet-tx-generator branch from 7407e34 to a21c4d8 Compare November 29, 2024 21:07
@abailly abailly force-pushed the abailly/demo-wallet-tx-generator branch from 008b97f to e169895 Compare November 30, 2024 12:31
@abailly
Copy link
Collaborator Author

abailly commented Dec 2, 2024

There's now a gen-multiple-txs.sh script that uses the gen-deposits.sh script to run a loop submitting transactions at a random interval. We have used it to populate the deposit wallet:

Screenshot 2024-12-02 at 10 24 58

Copy link
Collaborator

@paolino paolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@abailly abailly added this pull request to the merge queue Dec 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 6, 2024
@abailly abailly added this pull request to the merge queue Dec 6, 2024
Merged via the queue into master with commit ee160b6 Dec 6, 2024
24 checks passed
@abailly abailly deleted the abailly/demo-wallet-tx-generator branch December 6, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants