[ADP-3492] Retrieve genesis data from disk for the deposit wallet #4854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolino
force-pushed
the
paolino/ADP-3492/retrieve-genesis-data-from-disk
branch
3 times, most recently
from
077407f to
5dfdcd6
Compare
paolino
force-pushed
the
paolino/ADP-3492/retrieve-genesis-data-from-disk
branch
from
5dfdcd6 to
b5252c7
Compare
HeinrichApfelmus
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR substitute a mock implementation of GenesisData with one loaded from the disk. Because we do not have persistence yet this is not creating conflicts at the moment.
This allow us to run the deposit wallet in
preprodby supplying the preprod byron genesis fileWe also opportunistically fix the UI code to encode correctly addresses so that testnet addresses are now shown correctly.
GenesisDatafrom disk by specifying a filepath in the CLI argumentsGenesisDatanot propagated correctly in the REST interfaceADP-3492